1.5 KiB
docs/CombatNodeArchitecture.md — Review Log
Review — 2026-04-30 — Verdict: APPROVED
Scope signal: S Specialists: lean review (architecture constraint spec — internal doc, not player-facing GDD) Blocking items: 0 Recommended revisions: 3 (state transition table missing; LoopCount naming divergence from Node System; BossEffectiveHp formula not explicitly stated) Summary: Architecture constraint spec reviewed against adjusted GDD standards (no Player Fantasy, ACs, or Tuning Knobs expected). Document successfully constrains the combat domain with clear invariant enforcement, naming suffix conventions, and component boundaries. CombatNodeComponent facade pattern, CombatScheduler sole authority model, and InventoryGenerationComponent delegation are all well-specified. 3 recommended items are nice-to-haves. Prior verdict resolved: N/A (first review)
Review — 2026-04-30 — Verdict: APPROVED (addendum added)
Scope signal: S
Specialists: lean review
Blocking items: 0
Recommended revisions: 0 (prior 3 remain as nice-to-haves)
Summary: In-session addendum added §12 "Combat Economy" documenting the dual-currency architecture (Coin: combat-internal, Gold: run-level), sources, sinks, and the Progression coinEarned field semantics. Gap G1 from holistic review resolved — Coin economy was implemented but undocumented.
Prior verdict resolved: Yes — prior 3 recommendations remain unaddressed (nice-to-haves); G1 Coin economy documentation gap resolved via §12 addendum.